Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: Update profiles list on character change #199

Closed
1 task done
bharathkalyans opened this issue May 23, 2023 · 5 comments
Closed
1 task done

[Feat]: Update profiles list on character change #199

bharathkalyans opened this issue May 23, 2023 · 5 comments
Assignees
@bharathkalyans
Labels
enhancement New feature or request feature New Feature

Comments

@bharathkalyans
Copy link
Contributor

What feature?

  • Instead of clicking enter to get the result, we will update the profiles list for every character change.
  • This will make the search experience more better.

Add screenshots

See the below demo,

Feature.mov

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bharathkalyans bharathkalyans added the enhancement New feature or request label May 23, 2023
@bharathkalyans
Copy link
Contributor Author

  • Have PR ready! 😀

bharathkalyans added a commit to bharathkalyans/devFind that referenced this issue May 23, 2023
@bharathkalyans
feat: Adds the feature for issue shyamtawli#199
086ff2b
@bharathkalyans bharathkalyans mentioned this issue May 23, 2023
Merged
5 tasks
@shyamtawli shyamtawli added the feature New Feature label May 23, 2023
@bharathkalyans
Copy link
Contributor Author

@shyamtawli PR is ready, please review it!😀

@07prajwal2000
Copy link
Contributor

07prajwal2000 commented May 26, 2023 •
edited
Loading

Instead of updating the list on every character change, @bharathkalyans you can use Debounce, it will be more performant when having more profiles to search.
This could be a issue in mobiles when searching.

@07prajwal2000 07prajwal2000 mentioned this issue May 26, 2023
Closed
5 tasks
@07prajwal2000
Copy link
Contributor

07prajwal2000 commented May 26, 2023 •
edited
Loading

Please review PR: #218 @shyamtawli
which has the above changes mentioned in comments.

@shyamtawli
Copy link
Owner

@07prajwal2000 PR: #200 has been already merged, but I will look into your also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bharathkalyans bharathkalyans

Labels
enhancement New feature or request feature New Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bharathkalyans @07prajwal2000 @shyamtawli