feat: Add withdrawal message verification #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code did not check whether the
poolId
anddenom
ofmsg
matched in theWithdraw
function, leading to a vulnerability. Assuming Alice has two shares, ShareA and ShareB, when calling Withdraw, Alice sets thepoolId
inmsg
to the liquidity pool corresponding to ShareA but sets thedenom
to thedenom
of ShareB. In this case, the following code will not throw an error.https://github.com/sideprotocol/side/blob/47fc3fe9642c316865b5d3f8e07a1c1389a24029/x/gmm/keeper/msg_server_withdraw.go#L28-L30
In the end, Alice will successfully obtain tokens from the liquidity pool of PoolA by decreasing the shares of PoolB.