This repository has been archived by the owner on Jul 27, 2020. It is now read-only.
eslint-restricted-globals vs confusing-browser-globals #2
Comments
|
Yes, you are right. This package solves same problem confusing-browser-globals in create react app. It's a good idea to change eslint-config-airbnb-base to depend on the CRA package. |
edmorley
added a commit
to edmorley/javascript
that referenced
this issue
Nov 20, 2018
The `eslint-restricted-globals` package author created an equivalent package `confusing-browser-globals` that now resides within the create-react-app monorepo. In sidoshi/eslint-restricted-globals#2 @sidoshi suggested that we change eslint-config-airbnb-base to depend on the CRA package instead, in an effort to consolidate the two. Currently the two global lists are identical, so this does not change the generated eslint config: https://unpkg.com/[email protected]/index.js https://unpkg.com/[email protected]/index.js
|
Great :-) I've opened airbnb/javascript/pull/1961. |
|
Thank you for your work. |
ljharb
pushed a commit
to edmorley/javascript
that referenced
this issue
Nov 22, 2018
The `eslint-restricted-globals` package author created an equivalent package `confusing-browser-globals` that now resides within the create-react-app monorepo. In sidoshi/eslint-restricted-globals#2 @sidoshi suggested that we change eslint-config-airbnb-base to depend on the CRA package instead, in an effort to consolidate the two. Currently the two global lists are identical, so this does not change the generated eslint config: https://unpkg.com/[email protected]/index.js https://unpkg.com/[email protected]/index.js
kiku-jw
pushed a commit
to kiku-jw/javascript
that referenced
this issue
Mar 7, 2019
The `eslint-restricted-globals` package author created an equivalent package `confusing-browser-globals` that now resides within the create-react-app monorepo. In sidoshi/eslint-restricted-globals#2 @sidoshi suggested that we change eslint-config-airbnb-base to depend on the CRA package instead, in an effort to consolidate the two. Currently the two global lists are identical, so this does not change the generated eslint config: https://unpkg.com/[email protected]/index.js https://unpkg.com/[email protected]/index.js
|
To be sure, confusing-browser-globals is preferred over eslint-restricted-globals, right? |
|
@ypresto That's true. I will deprecate the package and archive this repo. Thanks for the suggestion. |
vunb
pushed a commit
to hsdt/javascript
that referenced
this issue
Nov 27, 2019
The `eslint-restricted-globals` package author created an equivalent package `confusing-browser-globals` that now resides within the create-react-app monorepo. In sidoshi/eslint-restricted-globals#2 @sidoshi suggested that we change eslint-config-airbnb-base to depend on the CRA package instead, in an effort to consolidate the two. Currently the two global lists are identical, so this does not change the generated eslint config: https://unpkg.com/[email protected]/index.js https://unpkg.com/[email protected]/index.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi!
I noticed that create-react-app now includes:
https://www.npmjs.com/package/confusing-browser-globals
...which seems to be identical to this package (and was authored by you in facebook/create-react-app#2286 :-))
It's just that eslint-config-airbnb-base depends on this package and not the newly created
confusing-browser-globals- so it seems like it might be worth trying to consolidate on one or the other?The text was updated successfully, but these errors were encountered: