Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-iot2050: Add the missing kbuildtarget #581

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BaochengSu
Copy link
Collaborator

The kbuildtarget is not set in the iot2050-debian.conf, this is causing both the kernels (cip & upstream) are be parsed and generated in the build process, which causes the parsing stage is very slow when connecting to github is not good.

@BaochengSu BaochengSu force-pushed the su/kernel-kbuild-upstream branch from ab15b0e to f834e18 Compare February 6, 2025 06:45
@@ -18,6 +18,8 @@ HOSTNAME ??= "iot2050-debian"

PREFERRED_VERSION_linux-iot2050 ?= "6.1.%"
PREFERRED_VERSION_linux-iot2050-rt ?= "6.1.%"
PREFERRED_VERSION_linux-iot2050-kbuildtarget ?= "6.1.%"
PREFERRED_VERSION_linux-iot2050-rt-kbuildtarget ?= "6.1.%"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep things a bit more maintainable, I would suggest this pattern:
https://gitlab.com/cip-project/cip-core/isar-cip-core/-/blob/master/conf/distro/cip-core-common.inc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acked and revised. BTW, sorry for the confusion, the kbuildtarget missing only confuse isar while choosing the correct kbuildtarget version, the upstream recipe is parsed regardless. This is because the "AUTOREV" in the upstream recipe. I append a new commit to address it, by masking the upstream recipe.

The kbuildtarget is not preset in the iot2050-debian.conf, which
confuses isar while choosing the correct kbuildtarget version.

Signed-off-by: Baocheng Su <[email protected]>
The AUTOREV used in the upstream recipe causes the recipe to be parsed
regardless, which makes the parsing stage very slow if the connection to
GitHub is not good.

Signed-off-by: Baocheng Su <[email protected]>
@BaochengSu BaochengSu force-pushed the su/kernel-kbuild-upstream branch from f834e18 to 031769f Compare February 10, 2025 07:55
PREFERRED_VERSION_linux-iot2050-rt ?= "6.1.%"
PREFERRED_VERSION_linux-iot2050-rt-kbuildtarget ?= "${PREFERRED_VERSION_linux-iot2050-rt}"
Copy link
Collaborator

@jan-kiszka jan-kiszka Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the missing PREFERRED_VERSION...-native bite you?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we append the -native to the linux-iot2050? How it looks like when it bites us? At least the recipe parsing has no problem and kernel/rt-kernel is building

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will see multiple provider warnings when bitbake identifies them during parsing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see any warnings... I guess due to isar version? Let me try

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-kbuildtarget and -native were introduced by the same isar changes. It takes two or more providers for those targets to make bitbake complain. I cannot explain, though, why 6.x-upstream should trigger the warning for kbuildtarget but not for native.

BTW, iot2050-linux-rt should only have one provider at this stage.

So much for the theory...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants