Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Userland PM16D17 #582

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Userland PM16D17 #582

wants to merge 2 commits into from

Conversation

BaochengSu
Copy link
Collaborator

@BaochengSu BaochengSu commented Feb 7, 2025

Upstream is hard for this chip driver, we decide to use userland driver instead.

Add restarting the service after adding the drop-in.

Signed-off-by: Baocheng Su <[email protected]>
The current PM16D17 kernel sensor driver is not using the existing
kernel API, but self-invented device tree bindings, which is rejected
while upstreaming, see [1].

This patch replaces the kernel driver with a user-land driver.

1. https://lore.kernel.org/linux-iio/[email protected]/

Signed-off-by: Baocheng Su <[email protected]>
@@ -15,6 +15,7 @@
from datetime import datetime
from systemd import journal
from enum import Enum
from pystemd.dbuslib import DBus, DbusMessage
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the event-record an identical user story?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a leakage due to the lack of kernel ABI or userspace API compatibility, which seems to be an unmanageable limitation.

Otherwise, looks good to me.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding our upcoming release, we may need to hold off on merging this PR to avoid involving additional third-party libraries for OSS clearance.

@jan-kiszka
Copy link
Collaborator

Quite a lot of changes... Given all this effort, it might have been worth to make at least the complications with Everlight transparent to upstream and ask for further guidance.

@BaochengSu
Copy link
Collaborator Author

Quite a lot of changes... Given all this effort, it might have been worth to make at least the complications with Everlight transparent to upstream and ask for further guidance.

Sure, I will append our new findings to the kernel mailing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants