Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding small corrections #292

Merged
merged 2 commits into from
Oct 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ The folder is created for you when you extract the project zip file.

Open a new Terminal session from the folder `sigma_public_embed` and run this command:

**Run the command tro install the Express web-server:**
**Run the command to install the Express web-server:**
```code
npm init
```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ The items in section #3 of the the embed-api.js code needs to be changed, replac
The items in section #6 need to be changed, replacing values for `email`, `external_user_id`, `external_user_team` and `account_type`.

<aside class="positive">
<strong>IMPORTANT:</strong><br> We are hard-coding the items in section #6 to keep this demonstration simple. In practice, these values would be generated programmatically bu the parent application and passed to the embed API at runtime, setting these values as appropriate for the user.
<strong>IMPORTANT:</strong><br> We are hard-coding the items in section #6 to keep this demonstration simple. In practice, these values would be generated programmatically but the parent application and passed to the embed API at runtime, setting these values as appropriate for the user.
</aside>

All other values can be left as they are.
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ Let's change the name of the new Workspace to something more descriptive. We wil

Once you’ve done this, embed-api.js (our server-side API from [QuickStart: Embedding 03: Secure Access.](https://quickstarts.sigmacomputing.com/guide/embedding_03_secure_access/index.html?index=..%2F..index#0)) needs to be updated to pass the new team value:

<img src="assets/fa7.png" width="800"/>
<img src="assets/fa-7a.png" width="800"/>

<aside class="negative">
<strong>NOTE:</strong><br> We reference embed-api.js only as an example of how the code looks, based on our example code in previous QuickStarts. It is assumed that your code may be different, but the value passed as a parameter will still need to be the same.
Expand Down
Loading