Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various grammar/typos in "Fundamentals" documents #297

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

ncurrault
Copy link
Contributor

@ncurrault ncurrault commented Oct 24, 2024

I noticed these when learning about Sigma:

  • Fundmentals 1
    • "it's release" (wrong "its")
    • "we can the default account types" (added missing word)
  • Fundmentals 2
    • "excel/google sheets" (capitalization)
  • Fundmentals 4
    • "(ie: write the function for you!)" (punctuation for "i.e." abbreviation)
    • "4.5+ record PLUGS_DATA table" (the table contains 4.5 million records, not just 4.5)
  • Fundmentals 6
    • "ensure this, of you don't" (misspelling)
  • Fundmentals 8
    • "joins effects" (wrong "affect"; subject-verb agreement)
    • "Linage" (misspelling)
    • "They are not stored in your cloud data warehouse or effect your source data in any way." (wrong "affect"; parallel structure)
    • "you have need more information" (unnecessary word)
    • "it's format" (wrong its)

@pballai pballai merged commit 931a943 into sigmacomputing:master Oct 24, 2024
1 check passed
@pballai
Copy link
Collaborator

pballai commented Oct 24, 2024

Thank you for your attention to detail Nickolas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants