-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Black or wrong image thumbnails #4732
Comments
More info
|
logs and shots follow in next comment Play store version, stock ROM (but rooted and Xposed, NO XPrivacy!) |
After forwarding the black thumbnail message to the same convo After sending that forward |
potentially fixed by #4737 |
I don't have the issue with the thumbnail above any more after updating to 3.6.0. 👍 |
🎆 |
I am running Signal 3.6.1 and experiencing the problem right now. Please reopen. |
|
@merkste maybe you could upload a log after you created a black thumbnail. And after you reentered the conversation that holds that black thumb. Is the image correctly shown, when you tap/open it? |
Weird, even more thumbnails turned black now. It happens in older conversation, too. @McLoo If I tab the thumbnail, the picture ist shown correctly. In the conversation list I did not yet see any black thumbnail.
In steps 2 - 4 I had to reenter the suspicious conversations |
Will you reopened this issue or should I start a new one? |
3.7.0, Nexus 4, stock 5.1.1 Log of one such case: https://gist.github.com/anonymous/3f795962df9fcaf4aa6b
This issue should be reopened. |
@mcginty do we know what commit introduced this? |
unfortunately no and still no repro on my install :/ |
I noticed something that may be related: After browsing "All Images" in a Conversation (with lots of images), the a wrong thumbnail image is displayed for the latest post. Tapping on the post brings up the correct picture but the thumbnail remains wrong. And by wrong I mean a thumbnail belonging to an older picture posted in the conversation. Don't know if my log is helpful here but: https://gist.github.com/anonymous/ee23b39dc4a347732996 |
|
I'm also having this issue in 3.8.1. It seems to only happen with high resolution images. |
It seems that there is something really messy going on in the database:
At some point the issue disappeared (unfortunately, i don't have a log for that) Then, trying to reproduce it by jumping from convo to convo, black thumbnails appeared instead of correct ones.... Signal 3.9.1, Android 5.1.1 |
Same problem here, this is my debug log |
First time seeing corrupted thumbnails. Log: https://gist.github.com/anonymous/4fdf4c5d8340651cdc04 "All images" view shows thumbnails properly |
I also see black image thumbnails from time to time. Pressing the images always displays them fine. Yesterday, in a group of 6 people one person (sender) shared a about 7 images and one movie. Don't know if related: The messages were sent at night from the USA, we opened them next morging in Germany. So there is a "time delay" maybe. On my phone (Samsung SIII mini), about three of these images were black as thumbnails: Log: https://gist.github.com/anonymous/89e82480ca3157308087 On a friend's phone (Samsung SIII), only one image was black. Interestingly, it was another image than on my phone. That is, same images sent but different ones showed up as black at the recipients. |
@mcginty With which Signal version comes the above mentioned glide update to 3.7.0? Signal 3.10 or Signal 3.11.1? |
@jnachtigall there hasn't been a patch yet. First rule of open source projects: never ask for an ETA 😜 |
Seems like the glide update comes with Signal 3.12. moxie commited 2 days ago: 170a429 Thx! ❤️ If the bug does not reoccur, we might close it after some time... |
I'm still getting this for about 50% of images. Low res, high res, doesn't seem to matter. This is anecdotal, but this only seems to happen in groups for me. |
Same here: With Signal 3.12.0 the black image thumbnails are gone mostly (for newer images), but some older ones remain black (images sent 3 weeks ago or so). Also only ever seen it in groups. |
Same here on two different phones! By the way, this was 1 on 1 with no groups involved |
I also sometimes had black pictures, when changing a groups profile picture. Not sure if related, when I want to send images, not all are shown, the preview is empty like some caching which doesn't update. |
Maybe check bumptech/glide#738 |
This just happened suddenly on 3.16.0 and spreads through all conversations. Preview is black, turns into real image after sending. Thumbnail will turn black after a while, don't know what it takes to turn it black though |
+1 i see the same thing on 3.16. (on CM 12.1) thumbnail was correct, after a while it suddenly turned black. |
Happend to me yesterday (3.19.0) after sending some Bitmojis. Now many thumbnails are black or turn black after some time. |
@btittelbach it's probably only the thumbnail that is cropped. The black background is, I think, due to your image being transparent (not related to this issue) |
I've been encountering (and continue to encounter) partially-black (some portion starting from the bottom) image previews within the conversation but pressing on them displays them correctly. This seems distinct from the fully-black previews others mention. Just now I encountered the wrong image being displayed in the image preview within a conversation. (I sent an image in that message, but the thumbnail displayed is the latest image I sent in a different conversation. The target is single-recipient SMS; the source is single-target Signal.) I'm using Signal 3.22.2. Is there more information I can provide? |
This is really bad. Happened to me just now with Signal 3.25.4. |
Some more findings:
|
4ad989c improved the situation (the quota of black previews has decreased), but this is still not fixed, some are still black. Conversation partner is on 3.24.0 (android7) and has no black previews at all, i am more or less on 4ad989c (android6) and still have black previews. Restarting signal/the entire phone has no effect. Log is complaining about a reconfigure call on a used bitmap:
|
Fixes signalapp/Signal-Android#4732 // FREEBIE Upstream commit: signalapp/Signal-Android@4ad989c
Fixes signalapp/Signal-Android#4732 // FREEBIE Upstream commit: signalapp/Signal-Android@4ad989c
#4612 and #4599 Spin-off
Just opened a convo with last message = outgoing text+ image message
Preview thumb in convo list showed up fine
In-convo the (attached from attachment drawer) image thumb is black
Reproduced two times now, on 2 tries opening the said convo
https://gist.github.com/9d319c95ba0757c7cebb
The text was updated successfully, but these errors were encountered: