Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5837 Disappearing Navigation Bar #5959

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarlowBrown
Copy link
Contributor

First time contributor checklist

Contributor checklist

  • My commits are rebased on the latest main branch
  • My commits are in nice logical chunks
  • My contribution is fully baked and is ready to be merged as is
  • I have tested my contribution on these devices:
  • iPhone 16, iOS 18.2
  • iPad Pro 13-inch M4, iOS 18.2

Description

This proposal fixes #5837 by provided a workaround the navigation bar disappearing. Exploring the codebase, there is no location where the navigation bar title view is hidden; however, as explained in the code comment in this PRs only commit, I am confident that this is a UIKit bug. This PR is a workaround until that UIKit bug is patched.

(cherry picked from commit 8b207d536e3b89b7d610ad226a479c0d14054944)
@sashaweiss-signal
Copy link
Contributor

I'm not wild about adding this workaround.

I can't trivially reproduce the issue on iOS 18.3 by rotating to landscape and back, so clearly something unreliable is going on. There's already a lot of unstable and hacky things already around Signal's nav bars, and I'm not inclined to add yet another instance without understanding the root cause. I worry that this will create more subtle problems down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants