Remove module and depend on upstream. #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
force-pushed
the
use_otel_release
branch
from
ed0af9e to
ba926bd
Compare
mateuszrzeszutek
approved these changes
Sep 22, 2023
| @@ -44,7 +44,8 @@ val otelAlphaVersion = otelVersion.replaceFirst("(-SNAPSHOT)?$".toRegex(), "-alp | |||
|
|
|||
| dependencies { | |||
| api(platform("io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha:$otelAlphaVersion")) | |||
| implementation(project(":opentelemetry-android-instrumentation")) | |||
| implementation("io.opentelemetry.android:instrumentation:0.1.0-alpha") | |||
There was a problem hiding this comment.
I wonder, should we perhaps expose it as an api dep?
Co-authored-by: Mateusz Rzeszutek <[email protected]>
breedx-splk
force-pushed
the
use_otel_release
branch
from
8d567fc to
770f4d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #629.
This is the first change that will remove the otel classes which now exist in upstream. We source it as a dependency.