Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make clippy happy #35

Conversation

mattsse
Copy link
Contributor

@mattsse mattsse commented Nov 10, 2024

removed all clippy warnings

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.76%. Comparing base (46e266c) to head (5b2468b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ssz/src/bitfield.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   77.76%   77.76%           
=======================================
  Files          12       12           
  Lines         715      715           
=======================================
  Hits          556      556           
  Misses        159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

I've opened an issue so we don't forget to add Clippy on CI:

@michaelsproul michaelsproul merged commit 545f25a into sigp:main Nov 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants