Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

const generic impls for [T; N] and SmallVec<[T; N]> #43

Merged
merged 1 commit into from
Feb 4, 2025
Merged

const generic impls for [T; N] and SmallVec<[T; N]> #43

merged 1 commit into from
Feb 4, 2025

Conversation

dknopik
Copy link
Member

@dknopik dknopik commented Jan 20, 2025

No description provided.

michaelsproul
michaelsproul approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much nicer than the old macro approach. Thank you!

@michaelsproul
Copy link
Member

@dapplion could I get a second pair of eyes on this when you have a sec?

dapplion
dapplion approved these changes Feb 3, 2025
View reviewed changes
Copy link

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Correct with spec

@michaelsproul michaelsproul merged commit d6819f6 into sigp:main Feb 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dknopik @michaelsproul @dapplion