Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update spec tests to v1.1.0-beta.4 #2548

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Update spec tests to v1.1.0-beta.4 #2548

wants to merge 3 commits into from

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Aug 27, 2021 •
edited
Loading

Proposed Changes

Bump the spec tests to beta.4, including the new randomised tests (which all pass 🎉)

@michaelsproul
Copy link
Member Author

The only new tests that are omitted currently are the BLS eth_fast_aggregate_verify/etc, because we don't have direct implementations of those functions to test. I'm undecided on whether we should write an implementation just so we can test it (I'm leaning towards yes: the more tests the better).

@michaelsproul michaelsproul added the work-in-progress PR is a work-in-progress label Aug 27, 2021
@michaelsproul michaelsproul added low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Sep 23, 2021
@michaelsproul michaelsproul changed the title Update spec tests to v1.1.0-beta.3 Update spec tests to v1.1.0-beta.4 Sep 23, 2021
@michaelsproul
Copy link
Member Author

michaelsproul commented Sep 23, 2021 •
edited
Loading

This is now ready for review 😊 I ended up adding runners for the new BLS tests.

I'm planning to add the other new BLS tests as part of a separate PR (i.e. the tests from here: https://github.com/ethereum/bls12-381-tests/)

@michaelsproul michaelsproul mentioned this pull request Sep 23, 2021
Closed
michaelsproul added a commit to michaelsproul/lighthouse that referenced this pull request Sep 24, 2021
@michaelsproul
Update to v1.1.0-beta.4 (squash of sigp#2548)
1ec13cb
@michaelsproul michaelsproul mentioned this pull request Sep 24, 2021
Merged
michaelsproul added a commit that referenced this pull request Sep 24, 2021
@michaelsproul
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
5a35ac0 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
paulhauner
paulhauner approved these changes Sep 25, 2021
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Sep 25, 2021
@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 25, 2021
@michaelsproul
Update spec tests to v1.1.0-beta.4 (#2548)
f5a17b5 
## Proposed Changes

Bump the spec tests to beta.4, including the new randomised tests (which all pass 🎉)
@bors
Copy link

bors bot commented Sep 25, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 25, 2021
@michaelsproul
Update spec tests to v1.1.0-beta.4 (#2548)
8a69e08 
## Proposed Changes

Bump the spec tests to beta.4, including the new randomised tests (which all pass 🎉)
@bors
Copy link

bors bot commented Sep 25, 2021

Build failed:

@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 25, 2021
@michaelsproul
Update spec tests to v1.1.0-beta.4 (#2548)
a844ce5 
## Proposed Changes

Bump the spec tests to beta.4, including the new randomised tests (which all pass 🎉)
@bors
Copy link

bors bot commented Sep 25, 2021

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Update spec tests to v1.1.0-beta.4 [Merged by Bors] - Update spec tests to v1.1.0-beta.4 Sep 25, 2021
@bors bors bot closed this Sep 25, 2021
paulhauner pushed a commit to paulhauner/lighthouse that referenced this pull request Sep 27, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (sigp#2622)
4759695 
* Update to v1.1.0-beta.4 (squash of sigp#2548)

* SSZ, cached tree hash, EF tests
realbigsean pushed a commit to realbigsean/lighthouse that referenced this pull request Sep 27, 2021
@michaelsproul @realbigsean
Fix consensus, SSZ, tree hash & run merge EF tests (sigp#2622)
08407b1 
* Update to v1.1.0-beta.4 (squash of sigp#2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit that referenced this pull request Sep 28, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
ef6158f 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit that referenced this pull request Oct 1, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
6da6453 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit that referenced this pull request Oct 12, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
1794886 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit that referenced this pull request Oct 27, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
82a1df5 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit to paulhauner/lighthouse that referenced this pull request Nov 3, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (sigp#2622)
b38203c 
* Update to v1.1.0-beta.4 (squash of sigp#2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit that referenced this pull request Nov 11, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
de84cdd 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit that referenced this pull request Nov 28, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
0c0fdbf 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit that referenced this pull request Nov 28, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
3b1a269 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit that referenced this pull request Dec 2, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
cce855f 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhauner paulhauner paulhauner approved these changes

Assignees
No one assigned
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsproul @paulhauner