Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy lints on merge-f2f #2626

Merged
merged 3 commits into from
Sep 25, 2021
Merged

Conversation

paulhauner
Copy link
Member

Issue Addressed

NA

Proposed Changes

Fixes all clippy lints on the merge-f2f branch.

Additional Info

NA

@paulhauner paulhauner added ready-for-review The code is ready for review merge-f2f Relates to the Oct 2021 Merge F2F labels Sep 25, 2021
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to merge once Clippy passes on this branch

@paulhauner
Copy link
Member Author

Clippy passed 🎉

@paulhauner paulhauner merged commit a99e8d7 into sigp:merge-f2f Sep 25, 2021
paulhauner added a commit to paulhauner/lighthouse that referenced this pull request Sep 27, 2021
* Remove unchecked arith from ssz_derive

* Address clippy lints in block_verfication

* Use safe math for is_valid_gas_limit
@paulhauner paulhauner mentioned this pull request Sep 27, 2021
7 tasks
realbigsean pushed a commit to realbigsean/lighthouse that referenced this pull request Sep 27, 2021
* Remove unchecked arith from ssz_derive

* Address clippy lints in block_verfication

* Use safe math for is_valid_gas_limit
realbigsean added a commit to realbigsean/lighthouse that referenced this pull request Sep 27, 2021
paulhauner added a commit that referenced this pull request Sep 28, 2021
* Remove unchecked arith from ssz_derive

* Address clippy lints in block_verfication

* Use safe math for is_valid_gas_limit
paulhauner added a commit that referenced this pull request Oct 1, 2021
* Remove unchecked arith from ssz_derive

* Address clippy lints in block_verfication

* Use safe math for is_valid_gas_limit
paulhauner added a commit that referenced this pull request Oct 12, 2021
* Remove unchecked arith from ssz_derive

* Address clippy lints in block_verfication

* Use safe math for is_valid_gas_limit
paulhauner added a commit that referenced this pull request Oct 27, 2021
* Remove unchecked arith from ssz_derive

* Address clippy lints in block_verfication

* Use safe math for is_valid_gas_limit
paulhauner added a commit to paulhauner/lighthouse that referenced this pull request Nov 3, 2021
* Remove unchecked arith from ssz_derive

* Address clippy lints in block_verfication

* Use safe math for is_valid_gas_limit
paulhauner added a commit that referenced this pull request Nov 11, 2021
* Remove unchecked arith from ssz_derive

* Address clippy lints in block_verfication

* Use safe math for is_valid_gas_limit
paulhauner added a commit that referenced this pull request Nov 28, 2021
* Remove unchecked arith from ssz_derive

* Address clippy lints in block_verfication

* Use safe math for is_valid_gas_limit
paulhauner added a commit that referenced this pull request Nov 28, 2021
* Remove unchecked arith from ssz_derive

* Address clippy lints in block_verfication

* Use safe math for is_valid_gas_limit
paulhauner added a commit that referenced this pull request Dec 2, 2021
* Remove unchecked arith from ssz_derive

* Address clippy lints in block_verfication

* Use safe math for is_valid_gas_limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-f2f Relates to the Oct 2021 Merge F2F ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants