Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store execution block hash in fork choice #2643

Conversation

realbigsean
Copy link
Member

See #2627

@realbigsean realbigsean added merge-f2f Relates to the Oct 2021 Merge F2F work-in-progress PR is a work-in-progress ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Sep 28, 2021
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, very tidy!

@paulhauner paulhauner merged commit 19925cc into sigp:merge-f2f Sep 28, 2021
paulhauner pushed a commit that referenced this pull request Sep 28, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete`
- Add database migration for the persisted fork choice

* update tests

* Small cleanup

* lints

* store execution block hash in fork choice rather than bool
paulhauner pushed a commit that referenced this pull request Oct 1, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete`
- Add database migration for the persisted fork choice

* update tests

* Small cleanup

* lints

* store execution block hash in fork choice rather than bool
paulhauner pushed a commit that referenced this pull request Oct 12, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete`
- Add database migration for the persisted fork choice

* update tests

* Small cleanup

* lints

* store execution block hash in fork choice rather than bool
paulhauner pushed a commit that referenced this pull request Oct 27, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete`
- Add database migration for the persisted fork choice

* update tests

* Small cleanup

* lints

* store execution block hash in fork choice rather than bool
realbigsean added a commit to realbigsean/lighthouse that referenced this pull request Nov 2, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete`
- Add database migration for the persisted fork choice

* update tests

* Small cleanup

* lints

* store execution block hash in fork choice rather than bool
paulhauner pushed a commit to paulhauner/lighthouse that referenced this pull request Nov 3, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete`
- Add database migration for the persisted fork choice

* update tests

* Small cleanup

* lints

* store execution block hash in fork choice rather than bool
paulhauner pushed a commit that referenced this pull request Nov 11, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete`
- Add database migration for the persisted fork choice

* update tests

* Small cleanup

* lints

* store execution block hash in fork choice rather than bool
paulhauner pushed a commit that referenced this pull request Nov 28, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete`
- Add database migration for the persisted fork choice

* update tests

* Small cleanup

* lints

* store execution block hash in fork choice rather than bool
paulhauner pushed a commit that referenced this pull request Nov 28, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete`
- Add database migration for the persisted fork choice

* update tests

* Small cleanup

* lints

* store execution block hash in fork choice rather than bool
paulhauner pushed a commit that referenced this pull request Dec 2, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete`
- Add database migration for the persisted fork choice

* update tests

* Small cleanup

* lints

* store execution block hash in fork choice rather than bool
@realbigsean realbigsean deleted the store-execution-block-hash-in-fork-choice branch November 21, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-f2f Relates to the Oct 2021 Merge F2F ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants