-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store execution block hash in fork choice #2643
Merged
paulhauner
merged 5 commits into
sigp:merge-f2f
from
realbigsean:store-execution-block-hash-in-fork-choice
Sep 28, 2021
Merged
Store execution block hash in fork choice #2643
paulhauner
merged 5 commits into
sigp:merge-f2f
from
realbigsean:store-execution-block-hash-in-fork-choice
Sep 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add database migration for the persisted fork choice
realbigsean
added
merge-f2f
Relates to the Oct 2021 Merge F2F
work-in-progress
PR is a work-in-progress
ready-for-review
The code is ready for review
and removed
work-in-progress
PR is a work-in-progress
labels
Sep 28, 2021
paulhauner
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, very tidy!
paulhauner
pushed a commit
that referenced
this pull request
Sep 28, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete` - Add database migration for the persisted fork choice * update tests * Small cleanup * lints * store execution block hash in fork choice rather than bool
paulhauner
pushed a commit
that referenced
this pull request
Oct 1, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete` - Add database migration for the persisted fork choice * update tests * Small cleanup * lints * store execution block hash in fork choice rather than bool
paulhauner
pushed a commit
that referenced
this pull request
Oct 12, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete` - Add database migration for the persisted fork choice * update tests * Small cleanup * lints * store execution block hash in fork choice rather than bool
paulhauner
pushed a commit
that referenced
this pull request
Oct 27, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete` - Add database migration for the persisted fork choice * update tests * Small cleanup * lints * store execution block hash in fork choice rather than bool
realbigsean
added a commit
to realbigsean/lighthouse
that referenced
this pull request
Nov 2, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete` - Add database migration for the persisted fork choice * update tests * Small cleanup * lints * store execution block hash in fork choice rather than bool
paulhauner
pushed a commit
to paulhauner/lighthouse
that referenced
this pull request
Nov 3, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete` - Add database migration for the persisted fork choice * update tests * Small cleanup * lints * store execution block hash in fork choice rather than bool
paulhauner
pushed a commit
that referenced
this pull request
Nov 11, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete` - Add database migration for the persisted fork choice * update tests * Small cleanup * lints * store execution block hash in fork choice rather than bool
paulhauner
pushed a commit
that referenced
this pull request
Nov 28, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete` - Add database migration for the persisted fork choice * update tests * Small cleanup * lints * store execution block hash in fork choice rather than bool
paulhauner
pushed a commit
that referenced
this pull request
Nov 28, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete` - Add database migration for the persisted fork choice * update tests * Small cleanup * lints * store execution block hash in fork choice rather than bool
paulhauner
pushed a commit
that referenced
this pull request
Dec 2, 2021
* - Update the fork choice `ProtoNode` to include `is_merge_complete` - Add database migration for the persisted fork choice * update tests * Small cleanup * lints * store execution block hash in fork choice rather than bool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2627