[Merged by Bors] - Consistent tracking of disconnected peers #2650
Conversation
| if matches!( | ||
| peer_info.connection_status(), | ||
| PeerConnectionStatus::Disconnected { .. } | ||
| ) { | ||
| self.disconnected_peers = self.disconnected_peers.saturating_sub(1); | ||
| } |
There was a problem hiding this comment.
Checking that I understand the logic here correctly:
We're about to change the peer's status from Disconnected -> Disconnecting, so we decrement the number of disconnected peers. Usually a short time later we will re-increment it when the peer transitions from Disconnecting -> Disconnected, right?
There was a problem hiding this comment.
Yep, see, confuuuuusing.
There was a problem hiding this comment.
We shouldn't really be disconnecting, peers that are already disconnected, but it can happen that an old peer in our db tries to connect to us, and we have too many peers, so we dont register it as connected and just move it straight to disconnecting.
There was a problem hiding this comment.
Damn, yeah, that's complicated.
michaelsproul
added
v2.0.0
|
bors r+ |
## Issue Addressed N/A ## Proposed Changes When peers switching to a disconnecting state, decrement the disconnected peers counter. This also downgrades some crit logs to errors. I've also added a re-sync point when peers get unbanned the disconnected peer count will match back to the number of disconnected peers if it has gone out of sync previously.
|
This PR was included in a batch that was canceled, it will be automatically retried |
## Issue Addressed N/A ## Proposed Changes When peers switching to a disconnecting state, decrement the disconnected peers counter. This also downgrades some crit logs to errors. I've also added a re-sync point when peers get unbanned the disconnected peer count will match back to the number of disconnected peers if it has gone out of sync previously.
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Issue Addressed
N/A
Proposed Changes
When peers switching to a disconnecting state, decrement the disconnected peers counter. This also downgrades some crit logs to errors.
I've also added a re-sync point when peers get unbanned the disconnected peer count will match back to the number of disconnected peers if it has gone out of sync previously.