-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.1.1 spec updates #2684
Merged
paulhauner
merged 8 commits into
sigp:merge-f2f
from
realbigsean:merge-initialize-from-eth1
Oct 8, 2021
Merged
v1.1.1 spec updates #2684
paulhauner
merged 8 commits into
sigp:merge-f2f
from
realbigsean:merge-initialize-from-eth1
Oct 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erge-initialize-from-eth1
realbigsean
added
blocked
merge-f2f
Relates to the Oct 2021 Merge F2F
ready-for-review
The code is ready for review
labels
Oct 6, 2021
paulhauner
requested changes
Oct 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome 🚀
There's just tiny typo to fix, then it's good to go.
Since we're just merging into merge-f2f
I think we should merge with those EF tests failing and wait for a good version.
It turns out I had permission to add those suggestions 🎉 If CI passes I'll merge it :) |
…meta.yml` in EF tests
…igsean/lighthouse into merge-initialize-from-eth1
paulhauner
added a commit
that referenced
this pull request
Oct 12, 2021
* update initializing from eth1 for merge genesis * read execution payload header from file lcli * add `create-payload-header` command to `lcli` * fix base fee parsing * Apply suggestions from code review * default `execution_payload_header` bool to false when deserializing `meta.yml` in EF tests Co-authored-by: Paul Hauner <[email protected]>
paulhauner
added a commit
that referenced
this pull request
Oct 27, 2021
* update initializing from eth1 for merge genesis * read execution payload header from file lcli * add `create-payload-header` command to `lcli` * fix base fee parsing * Apply suggestions from code review * default `execution_payload_header` bool to false when deserializing `meta.yml` in EF tests Co-authored-by: Paul Hauner <[email protected]>
paulhauner
added a commit
to paulhauner/lighthouse
that referenced
this pull request
Nov 3, 2021
* update initializing from eth1 for merge genesis * read execution payload header from file lcli * add `create-payload-header` command to `lcli` * fix base fee parsing * Apply suggestions from code review * default `execution_payload_header` bool to false when deserializing `meta.yml` in EF tests Co-authored-by: Paul Hauner <[email protected]>
paulhauner
added a commit
that referenced
this pull request
Nov 11, 2021
* update initializing from eth1 for merge genesis * read execution payload header from file lcli * add `create-payload-header` command to `lcli` * fix base fee parsing * Apply suggestions from code review * default `execution_payload_header` bool to false when deserializing `meta.yml` in EF tests Co-authored-by: Paul Hauner <[email protected]>
paulhauner
added a commit
that referenced
this pull request
Nov 28, 2021
* update initializing from eth1 for merge genesis * read execution payload header from file lcli * add `create-payload-header` command to `lcli` * fix base fee parsing * Apply suggestions from code review * default `execution_payload_header` bool to false when deserializing `meta.yml` in EF tests Co-authored-by: Paul Hauner <[email protected]>
paulhauner
added a commit
that referenced
this pull request
Nov 28, 2021
* update initializing from eth1 for merge genesis * read execution payload header from file lcli * add `create-payload-header` command to `lcli` * fix base fee parsing * Apply suggestions from code review * default `execution_payload_header` bool to false when deserializing `meta.yml` in EF tests Co-authored-by: Paul Hauner <[email protected]>
paulhauner
added a commit
that referenced
this pull request
Dec 2, 2021
* update initializing from eth1 for merge genesis * read execution payload header from file lcli * add `create-payload-header` command to `lcli` * fix base fee parsing * Apply suggestions from code review * default `execution_payload_header` bool to false when deserializing `meta.yml` in EF tests Co-authored-by: Paul Hauner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
initialize_beacon_state_from_eth1
lcli new-testnet --execution-payload-header FILE
to allow starting from a merge genesis with or without an execution payload headerlcli create-payload-header
command to create the file used in the prior command ^Additional Info