Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update next_fork_subscriptions correctly #2688

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Update next_fork_subscriptions correctly #2688

wants to merge 1 commit into from

Conversation

pawanjay176
Copy link
Member

Issue Addressed

N/A

Proposed Changes

Update the next_fork_subscriptions timer only after a fork happens.

@pawanjay176 pawanjay176 changed the base branch from merge-f2f to unstable October 12, 2021 10:57
@pawanjay176 pawanjay176 force-pushed the fix-fork-subscriptions branch from c320b9d to a1fe5a8 Compare October 12, 2021 10:57
@pawanjay176 pawanjay176 added the ready-for-review The code is ready for review label Oct 12, 2021
AgeManning
AgeManning approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should also start looking into improving the fork update logic, assuming we are not making another release before mainnet fork.

@AgeManning
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 21, 2021
@pawanjay176
Update next_fork_subscriptions correctly (#2688)
de34001 
## Issue Addressed

N/A

## Proposed Changes

Update the `next_fork_subscriptions` timer only after a fork happens.
@bors
Copy link

bors bot commented Oct 21, 2021

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Update next_fork_subscriptions correctly [Merged by Bors] - Update next_fork_subscriptions correctly Oct 21, 2021
@bors bors bot closed this Oct 21, 2021
@pawanjay176 pawanjay176 deleted the fix-fork-subscriptions branch October 21, 2021 16:59
@pawanjay176
Copy link
Member Author

LGTM. We should also start looking into improving the fork update logic, assuming we are not making another release before mainnet fork.

I think what Mark implemented in #2619 is a good fork-agnostic solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgeManning AgeManning AgeManning approved these changes

Assignees
No one assigned
Labels
ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawanjay176 @AgeManning