Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix Docker run -p for both TCP and UDP #2998

Closed
wants to merge 1 commit into from

Conversation

ladidan
Copy link
Contributor

@ladidan ladidan commented Feb 6, 2022

Issue Addressed

[Docker run] ... "-p 9000:9000" defaults to expose TCP only.

Proposed Changes

Add "-p 9000:9000/udp" for UDP peer discovery.

[Docker run] ... "-p 9000:9000" defaults to expose TCP only.
Add "-p 9000:9000/udp" for UDP peer discovery.
@ladidan ladidan marked this pull request as ready for review February 6, 2022 15:41
@paulhauner paulhauner added the ready-for-review The code is ready for review label Feb 7, 2022
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

bors r+

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 7, 2022
bors bot pushed a commit that referenced this pull request Feb 7, 2022
## Issue Addressed

[Docker run] ... "-p 9000:9000" defaults to expose TCP only.

## Proposed Changes

Add "-p 9000:9000/udp" for UDP peer discovery.
@bors
Copy link

bors bot commented Feb 7, 2022

Build failed:

@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 7, 2022
## Issue Addressed

[Docker run] ... "-p 9000:9000" defaults to expose TCP only.

## Proposed Changes

Add "-p 9000:9000/udp" for UDP peer discovery.
@paulhauner
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Feb 7, 2022

Canceled.

@AgeManning
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 7, 2022
## Issue Addressed

[Docker run] ... "-p 9000:9000" defaults to expose TCP only.

## Proposed Changes

Add "-p 9000:9000/udp" for UDP peer discovery.
@paulhauner
Copy link
Member

bors r+

@bors
Copy link

bors bot commented Feb 7, 2022

Already running a review

@paulhauner
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Feb 7, 2022

Canceled.

@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 7, 2022
## Issue Addressed

[Docker run] ... "-p 9000:9000" defaults to expose TCP only.

## Proposed Changes

Add "-p 9000:9000/udp" for UDP peer discovery.
@bors bors bot changed the title Fix Docker run -p for both TCP and UDP [Merged by Bors] - Fix Docker run -p for both TCP and UDP Feb 8, 2022
@bors bors bot closed this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants