[Merged by Bors] - Ensure logfile respects the validators-dir CLI flag #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macladson
commented
Feb 7, 2022
paulhauner
approved these changes
Feb 16, 2022
paulhauner
added
waiting-on-author
macladson
added
ready-for-review
michaelsproul
requested changes
Feb 23, 2022
michaelsproul
added
waiting-on-author
michaelsproul
added
ready-for-merge
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 24, 2022
## Issue Addressed Closes #2990 ## Proposed Changes Add a check to see if the `--validators-dir` CLI flag is set and if so store validator logs into it. Ensure that if the log directory cannot be created, emit a `WARN` and disable file logging rather than panicking. ## Additional Info Panics associated with logfiles can still occur in these scenarios: 1. The `$datadir/validators/logs` directory already exists with the wrong permissions (or was changed after creation). 1. The logfile already exists with the wrong permissions (or was changed after creation). > These panics are cosmetic only since only the logfile thread panics. Following the panics, LH will continue to function as normal. I believe this is due to the use of [`slog::Fuse`](https://docs.rs/slog/latest/slog/struct.Fuse.html) when initializing the logger. I'm not sure if there a better way of handling logfile errors? I think ideally, rather than panicking, we would emit a `WARN` to the stdout logger with the panic reason, then exit the logfile thread gracefully.
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #2990
Proposed Changes
Add a check to see if the
--validators-dirCLI flag is set and if so store validator logs into it.Ensure that if the log directory cannot be created, emit a
WARNand disable file logging rather than panicking.Additional Info
Panics associated with logfiles can still occur in these scenarios:
$datadir/validators/logsdirectory already exists with the wrong permissions (or was changed after creation).I believe this is due to the use of
slog::Fusewhen initializing the logger.I'm not sure if there a better way of handling logfile errors?
I think ideally, rather than panicking, we would emit a
WARNto the stdout logger with the panic reason, then exit the logfile thread gracefully.