-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Update to Rust 1.59 and 2021 edition #3038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
The code is ready for review
low-hanging-fruit
Easy to resolve, get it before someone else does!
labels
Feb 24, 2022
AgeManning
approved these changes
Feb 24, 2022
michaelsproul
changed the title
Fix Rust 1.59.0 lints
Update to Rust 1.59 and 2021 edition
Feb 24, 2022
bors r+ |
michaelsproul
added
ready-for-merge
This PR is ready to merge.
and removed
ready-for-review
The code is ready for review
labels
Feb 24, 2022
bors bot
pushed a commit
that referenced
this pull request
Feb 24, 2022
## Proposed Changes Lots of lint updates related to `flat_map`, `unwrap_or_else` and string patterns. I did a little more creative refactoring in the op pool, but otherwise followed Clippy's suggestions. ## Additional Info We need this PR to unblock CI.
Build failed: |
Hmm, looks like 2021 broke some macros. Will fix. |
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Feb 25, 2022
## Proposed Changes Lots of lint updates related to `flat_map`, `unwrap_or_else` and string patterns. I did a little more creative refactoring in the op pool, but otherwise followed Clippy's suggestions. ## Additional Info We need this PR to unblock CI.
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Update to Rust 1.59 and 2021 edition
[Merged by Bors] - Update to Rust 1.59 and 2021 edition
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
low-hanging-fruit
Easy to resolve, get it before someone else does!
ready-for-merge
This PR is ready to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Lots of lint updates related to
flat_map
,unwrap_or_else
and string patterns. I did a little more creative refactoring in the op pool, but otherwise followed Clippy's suggestions.Additional Info
We need this PR to unblock CI.