Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update to Rust 1.59 and 2021 edition #3038

Closed
wants to merge 5 commits into from

Conversation

michaelsproul
Copy link
Member

Proposed Changes

Lots of lint updates related to flat_map, unwrap_or_else and string patterns. I did a little more creative refactoring in the op pool, but otherwise followed Clippy's suggestions.

Additional Info

We need this PR to unblock CI.

@michaelsproul michaelsproul added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! labels Feb 24, 2022
@michaelsproul michaelsproul changed the title Fix Rust 1.59.0 lints Update to Rust 1.59 and 2021 edition Feb 24, 2022
@michaelsproul
Copy link
Member Author

bors r+

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 24, 2022
bors bot pushed a commit that referenced this pull request Feb 24, 2022
## Proposed Changes

Lots of lint updates related to `flat_map`, `unwrap_or_else` and string patterns. I did a little more creative refactoring in the op pool, but otherwise followed Clippy's suggestions.

## Additional Info

We need this PR to unblock CI.
@bors
Copy link

bors bot commented Feb 24, 2022

Build failed:

@michaelsproul
Copy link
Member Author

Hmm, looks like 2021 broke some macros. Will fix.

@michaelsproul
Copy link
Member Author

bors retry

bors bot pushed a commit that referenced this pull request Feb 25, 2022
## Proposed Changes

Lots of lint updates related to `flat_map`, `unwrap_or_else` and string patterns. I did a little more creative refactoring in the op pool, but otherwise followed Clippy's suggestions.

## Additional Info

We need this PR to unblock CI.
@bors bors bot changed the title Update to Rust 1.59 and 2021 edition [Merged by Bors] - Update to Rust 1.59 and 2021 edition Feb 25, 2022
@bors bors bot closed this Feb 25, 2022
@michaelsproul michaelsproul deleted the rust-1.59 branch February 25, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants