[Merged by Bors] - Fix ganache in windows CI #3105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realbigsean
changed the title
bors bot
pushed a commit
that referenced
this pull request
Mar 21, 2022
## Issue Addressed Hopefully makes windows ganache installation more reliable. ## Proposed Changes - use `chocolatey` to install windows build tools. This seems to often be the prescribed solution for `node gyp` issues. `chocolatey` is used here because `npm install --global --production windows-build-tools` hangs in github actions ## Additional Info I still haven't found why the prior installation technique would sometimes work, the `windows-2019` environments seem to be identical across successes and failures. I think this should be re-run a few times to see if it can consistently pass Co-authored-by: realbigsean <[email protected]>
michaelsproul
added
ready-for-merge
bors
bot
changed the title
divagant-martian
pushed a commit
to divagant-martian/lighthouse
that referenced
this pull request
Mar 22, 2022
## Issue Addressed Hopefully makes windows ganache installation more reliable. ## Proposed Changes - use `chocolatey` to install windows build tools. This seems to often be the prescribed solution for `node gyp` issues. `chocolatey` is used here because `npm install --global --production windows-build-tools` hangs in github actions ## Additional Info I still haven't found why the prior installation technique would sometimes work, the `windows-2019` environments seem to be identical across successes and failures. I think this should be re-run a few times to see if it can consistently pass Co-authored-by: realbigsean <[email protected]>
paulhauner
pushed a commit
to paulhauner/lighthouse
that referenced
this pull request
May 6, 2022
## Issue Addressed Hopefully makes windows ganache installation more reliable. ## Proposed Changes - use `chocolatey` to install windows build tools. This seems to often be the prescribed solution for `node gyp` issues. `chocolatey` is used here because `npm install --global --production windows-build-tools` hangs in github actions ## Additional Info I still haven't found why the prior installation technique would sometimes work, the `windows-2019` environments seem to be identical across successes and failures. I think this should be re-run a few times to see if it can consistently pass Co-authored-by: realbigsean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Hopefully makes windows ganache installation more reliable.
Proposed Changes
chocolateyto install windows build tools. This seems to often be the prescribed solution fornode gypissues.chocolateyis used here becausenpm install --global --production windows-build-toolshangs in github actionsAdditional Info
I still haven't found why the prior installation technique would sometimes work, the
windows-2019environments seem to be identical across successes and failures. I think this should be re-run a few times to see if it can consistently pass