Update engine_api to latest version
#4223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couple compile errors, but looks good otherwise! |
realbigsean
reviewed
Apr 26, 2023
| .into(); | ||
| (signed_block, Some(signed_blobs)) | ||
| } else { | ||
| // idk what else to put here.. |
There was a problem hiding this comment.
Suggested change
| // idk what else to put here.. |
crypto/kzg/src/kzg_commitment.rs
Outdated
|
|
||
| #[derive(Derivative, Clone, Copy, Encode, Decode)] | ||
| #[derivative(PartialEq, Eq, Hash)] | ||
| #[ssz(struct_behaviour = "transparent")] | ||
| pub struct KzgCommitment(pub [u8; BYTES_PER_COMMITMENT]); | ||
|
|
||
| impl KzgCommitment { | ||
| pub fn calculate_versioned_hash(&self) -> Hash256 { | ||
| let mut versioned_hash = hash(&self.0); |
There was a problem hiding this comment.
any reason not to use hash_fixed?
realbigsean
approved these changes
Apr 27, 2023
This was referenced Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Updated the
engine_apimethods to match the latest version & updated themock_execution_layerto produce blobs and now the testing harness works properly on thedenebfork. Created tests using these changes on myoverflow_lru_cachebranch that uses these changes and they seem to work.