-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue 4860 - Added in process_justification_and_finalization #4877
Fix for issue 4860 - Added in process_justification_and_finalization #4877
Conversation
Added in process_justification_and_finalization to compute_attestation_rewards_altair to take into account justified attestations when coming out of inactivity leak. Also added in test to check for this edge case.
@jimmygchen hey, I added in the logic |
Good point. I think we do, as phase0 rewards calculation also uses |
@michaelsproul sounds good, I will get the logic added for phase0 and tested as well |
@michaelsproul I have added in the logic for phase0 to process the justification and finalization and added in tests to ensure it is working as expected. |
@michaelsproul @jimmygchen this PR is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @zack-scott
Issue Addressed
This PR addresses the issue of compute_attestation_rewards_altair not taking into account the justified epochs attestation rewards when coming out of an inactivity leak.
Which issue # does this PR address?
#4860
Proposed Changes
Added in process_justification_and_finalization to the compute_attestation_rewards_altair function as suggested in issue.
Please list or describe the changes introduced by this PR.
The changes allow for calculation of attestation rewards when coming out of an inactivity leak.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.