Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update goerli config #5036

Merged
merged 1 commit into from
Jan 8, 2024
Merged

update goerli config #5036

merged 1 commit into from
Jan 8, 2024

Conversation

realbigsean
Copy link
Member

Issue Addressed

eth-clients/goerli#178

@realbigsean realbigsean added ready-for-review The code is ready for review deneb v4.6.0 ETA Q1 2024 labels Jan 5, 2024
@jimmygchen jimmygchen self-assigned this Jan 7, 2024
jimmygchen
jimmygchen approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just a note that I couldn't find usage of the ATTESTATION_PROPAGATION_SLOT_RANGE in our code, so it looks like we might not be using this.

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 7, 2024
@jimmygchen jimmygchen merged commit db05d37 into sigp:unstable Jan 8, 2024
28 checks passed
@chenrui333 chenrui333 mentioned this pull request Jan 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees

@jimmygchen jimmygchen

Labels
deneb ready-for-merge This PR is ready to merge. v4.6.0 ETA Q1 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realbigsean @jimmygchen