improve libp2p connected peer metrics #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
force-pushed
the
improve-metrics-2
branch
from
66c259b to
9cd74a2
Compare
AgeManning
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Have we run these changes?
We've switched from setting the gauges for connected to peers to solely relying on increment and decrement. I'm worried there's a thousand edge-cases where peers disconnect/connect and we don't account for them putting these metrics off.
If the peer-count metric is off, it will be something we'll need to fix urgently.
jxs
force-pushed
the
improve-metrics-2
branch
from
9cd74a2 to
49d42f1
Compare
AgeManning
approved these changes
Feb 28, 2024
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at a89ff10 |
5 tasks
pawanjay176
pushed a commit
to pawanjay176/lighthouse
that referenced
this pull request
Mar 5, 2024
* patch rust-yamux dep * improve libp2p connected peer metrics
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
submits #4870 reworked with #5265 addressed:
libp2p_peers_connectedmetric as its standardPEERS_CONNECTED_MULTIwhich contains the sum of all the peers connected as anIntGaugeVecwhich means it descriminates per direction and transportNETWORK_INBOUND_PEERSandNETWORK_INBOUND_PEERSas they are covered byPEERS_CONNECTED_MULTIand are not standardDISCOVERY_BYTESwhich gathers all the transferred discovery bytes which can be discriminated by outbound and inbound.DISCOVERY_SENT_BYTESandDISCOVERY_RECV_BYTESas they are covered byDISCOVERY_BYTESupdate_connected_peer_metricsfunction, we increment and decrement the number of peers onPeerManagerNetworkBehaviour'sFromSwarm::ConnectionEstablishedandFromSwarm::ConnectionClosedevents, andPEERS_PER_CLIENTis already updated when we identify a client.