Skip creating child lookup if parent is never created

[dapplion]

Issue Addressed

Debugging das branch noted this warn

May 17 06:32:09.911 WARN Ignoring child lookup parent lookup not found, block_root: 0x9472cd41881dd39cd9148d06392c0fb9d3d059602a2056ba9c0641107b29ac3c, service: lookup_sync, service: sync
May 17 06:32:09.913 WARN Ignoring child lookup parent lookup not found, block_root: 0x9472cd41881dd39cd9148d06392c0fb9d3d059602a2056ba9c0641107b29ac3c, service: lookup_sync, service: sync
May 17 06:32:09.914 WARN Ignoring child lookup parent lookup not found, block_root: 0x9472cd41881dd39cd9148d06392c0fb9d3d059602a2056ba9c0641107b29ac3c, service: lookup_sync, service: sync
May 17 06:32:09.914 WARN Ignoring child lookup parent lookup not found, block_root: 0x9472cd41881dd39cd9148d06392c0fb9d3d059602a2056ba9c0641107b29ac3c, service: lookup_sync, service: sync

It happens because of a bug in new_current_lookup. This function declares

    /// Returns true if the lookup is created or already exists

But if the lookup is completed immediately in

        let result = lookup.continue_requests(cx);

This API contract breaks

Proposed Changes

new_current_lookup returns false if continue_requests drops the lookup

[jimmygchen]

LGTM!

[jimmygchen]

@mergify queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 319b4a2