De-duplicate enable_light_client_server
#6988
Conversation
|
|
|
This pull request has merge conflicts. Could you please resolve them @EllipticPoint? 🙏 |
| @@ -155,7 +155,7 @@ pub struct Config { | |||
| pub enable_beacon_processor: bool, | |||
| #[serde(with = "eth2::types::serde_status_code")] | |||
| pub duplicate_block_status_code: StatusCode, | |||
| pub enable_light_client_server: bool, | |||
| pub enable_light_client_server: Arc<bool>, | |||
There was a problem hiding this comment.
I don't think this really addresses the problem of there not being a single source of truth. It's the same situation as before with three struct fields, and they're manually kept in sync.
If you don't mind, I'll just close this PR, as I think to achieve the single-source-of-truth would be a larger refactor that probably isn't worth doing atm.
There was a problem hiding this comment.
This is more along the lines of what I was thinking:
Maybe you could extend my PR to remove the config field from the network crate?
There was a problem hiding this comment.
Happy to close this PR as I don't think I'll have the time anytime soon to properly do a larger refactor.
There was a problem hiding this comment.
Nws, thanks for your efforts nonetheless!
Issue Addressed
#6959
Proposed Changes
Arc<bool>type to create a single source of truthenable_light_client_server: Arc<bool>has been added toConfig.Arc<bool>