Add missing error log and remove redundant id field from lookup logs #6990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
added
ready-for-review
dapplion
reviewed
Feb 12, 2025
| "id" => %id, | ||
| "error" => e | ||
| ) | ||
| }) |
dapplion
reviewed
Feb 12, 2025
| @@ -179,7 +176,6 @@ impl<T: BeaconChainTypes> ActiveCustodyRequest<T> { | |||
| Err(err) => { | |||
| debug!(self.log, | |||
| "Custody column download error"; | |||
| "id" => ?self.custody_id, | |||
There was a problem hiding this comment.
This is a good fix as req_id includes custody_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Partially #6989.
This PR adds the missing error log when a batch fails due to issues with converting the response into
RpcBlock. See the above linked issue for more details.Adding this log reveals that we're completing range requests with missing columns, hence causing the batch to fail. It looks like we've hit the case where we've received enough stream terminations, but not all columns are returned.
I've also removed some redundant
idlogging, as theiddebug representation is difficult to read, and is now being logged as part ofreq_idin a more succinct format (relevant PR: #6914)