Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix execution engine integration tests with latest geth version #6996

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from
Open

Fix execution engine integration tests with latest geth version #6996

wants to merge 2 commits into from
+466 −66

Conversation

EllipticPoint
Copy link
Member

@EllipticPoint EllipticPoint commented Feb 13, 2025 •
edited
Loading

Issue Addressed

#6937

Proposed Changes

  • Use ethers-rs Signer middleware for local signing and sending raw txs to geth
  • Set totalDifficulty = 0 through serde default if the block does not contain a totalDifficulty field

@jimmygchen jimmygchen added the test improvement Improve tests label Feb 13, 2025
@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-for-review The code is ready for review test improvement Improve tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EllipticPoint @jimmygchen