Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement new beacon APIs(accessors for pending_deposits/pending_partial_withdrawals) #7006

Draft
wants to merge 4 commits into
base: unstable
Choose a base branch
from
Draft

feat: implement new beacon APIs(accessors for pending_deposits/pending_partial_withdrawals) #7006

wants to merge 4 commits into from

Conversation

syjn99
Copy link

@syjn99 syjn99 commented Feb 15, 2025 •
edited
Loading

Issue Addressed

Resolves #7003

Proposed Changes

Please list or describe the changes introduced by this PR.

Additional Info

As #7007 breaks current test set-up, will be test after the change is applied to unstable

michaelsproul
michaelsproul reviewed Feb 15, 2025
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at a glance, you're definitely on the right track. I've triggered CI so you can see if the tests pass. You can also run locally, just not in debug mode

beacon_node/http_api/src/lib.rs Outdated Show resolved Hide resolved
@michaelsproul
Copy link
Member

michaelsproul commented Feb 17, 2025 •
edited
Loading

You can fix the cargo format failure by running cargo fmt --all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syjn99 @michaelsproul