Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types.md #2322

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Update types.md #2322

merged 1 commit into from
Jan 9, 2025

Conversation

sgpinkus
Copy link
Contributor

@sgpinkus sgpinkus commented Jan 9, 2025

Add link to HashedRekord

Summary

Release Note

Documentation

Add link to HashedRekord

Signed-off-by: sgpinkus <[email protected]>
@sgpinkus sgpinkus requested a review from a team as a code owner January 9, 2025 22:19
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Note that this doc is out of date and is missing a number of new types, and also conflates entry types (e.g. hashedrekord) with signature verifiers (e.g. ssh, x509)

@haydentherapper haydentherapper enabled auto-merge (squash) January 9, 2025 22:20
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.89%. Comparing base (488eb97) to head (0e4a0c0).
Report is 275 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2322       +/-   ##
===========================================
- Coverage   66.46%   49.89%   -16.57%     
===========================================
  Files          92      192      +100     
  Lines        9258    24683    +15425     
===========================================
+ Hits         6153    12316     +6163     
- Misses       2359    11276     +8917     
- Partials      746     1091      +345     
Flag Coverage Δ
e2etests 46.49% <ø> (-1.06%) ⬇️
unittests 41.91% <ø> (-5.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haydentherapper haydentherapper merged commit 513c30e into sigstore:main Jan 9, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants