Allow an expired certificate chain to be uploaded and verified #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #873 +/- ##
==========================================
+ Coverage 46.34% 46.36% +0.02%
==========================================
Files 60 60
Lines 5135 5137 +2
==========================================
+ Hits 2380 2382 +2
Misses 2482 2482
Partials 273 273
Continue to review full report at Codecov.
|
This causes issues when trying to look up an entry where the chain was valid/unexpired when uploaded, but has since expired when it's retreived. Signed-off-by: Hayden Blauzvern <[email protected]> Signed-off-by: Hayden Blauzvern <[email protected]>
haydentherapper
force-pushed
the
allow-expired-chain
branch
from
6981259 to
0e6b697
Compare
|
@cpanato We'll need a new cut to release this bug fix |
dlorenc
approved these changes
Jun 15, 2022
|
@haydentherapper preparing the changelog and as soon we merge this i can cut a release |
|
PR #874 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes issues when trying to look up an entry where the chain was
valid/unexpired when uploaded, but has since expired when it's
retreived.
Signed-off-by: Hayden Blauzvern [email protected]
Summary
Ticket Link
Fixes
Release Note