Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus summary to track metric latency #966

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

priyawadhwa
Copy link
Contributor

The summary will allow us to use more aggregations across data, including max().
This will be useful for debugging noisy latency alerts and getting more info about latency.

ref https://github.com/sigstore/public-good-instance/issues/533

Signed-off-by: Priya Wadhwa [email protected]

Summary

Release Note

Documentation

The summary will allow us to use more aggregations across data, including max().
This will be useful for debugging noisy latency alerts.

Signed-off-by: Priya Wadhwa <[email protected]>
@priyawadhwa priyawadhwa requested a review from a team as a code owner August 11, 2022 20:21
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@priyawadhwa priyawadhwa merged commit f9f283e into sigstore:main Aug 11, 2022
@priyawadhwa priyawadhwa deleted the prometheus branch August 11, 2022 21:31
@github-actions github-actions bot added this to the v1.0.0 milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants