Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_cli: refactor logging behavior #372

Merged
merged 4 commits into from
Dec 28, 2022
Merged

_cli: refactor logging behavior #372

merged 4 commits into from
Dec 28, 2022

Conversation

woodruffw
Copy link
Member

This refactors sigstore's logging behavior to the following:

  1. SIGSTORE_LOGLEVEL now only affects the sigstore.* logger hierarchy
  2. -v is added as an additive option;
    1. -v corresponds to SIGSTORE_LOGLEVEL=debug
    2. -vv corresponds to <root logger>.setLevel("DEBUG")

cc @jku

Closes #371.

Signed-off-by: William Woodruff [email protected]

@woodruffw
_cli: refactor logging behavior
81063ac 
Closes #371.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw added component:cli CLI components refactoring Refactoring tasks. labels Dec 27, 2022
@woodruffw woodruffw requested review from di and tetsuo-cpp December 27, 2022 17:57
@woodruffw woodruffw self-assigned this Dec 27, 2022
@woodruffw
CHANGELOG: record changes
41d6749 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
README: update sigstore --help
b8ff921 
Signed-off-by: William Woodruff <[email protected]>
woodruffw added a commit to pypa/pip-audit that referenced this pull request Dec 27, 2022
@woodruffw
_cli: refactor logging
a653f08 
This is inspired by the refactor in
sigstore/sigstore-python#372.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw mentioned this pull request Dec 27, 2022
Merged
@woodruffw
_cli: fold level variable
62ba47d 
Signed-off-by: William Woodruff <[email protected]>
tetsuo-cpp
tetsuo-cpp approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tetsuo-cpp tetsuo-cpp merged commit f0ffcba into main Dec 28, 2022
@tetsuo-cpp tetsuo-cpp deleted the ww/better-logging-defaults branch December 28, 2022 00:54
tetsuo-cpp pushed a commit to pypa/pip-audit that referenced this pull request Dec 28, 2022
@woodruffw
_cli: refactor logging (#452)
635bd97 
* _cli: refactor logging

This is inspired by the refactor in
sigstore/sigstore-python#372.

Signed-off-by: William Woodruff <[email protected]>

* README: update `pip-audit --help`

Signed-off-by: William Woodruff <[email protected]>

Signed-off-by: William Woodruff <[email protected]>
woodruffw added a commit to pypa/pip-audit that referenced this pull request Dec 28, 2022
@woodruffw
_cli: refactor logging (#452)
d86a214 
* _cli: refactor logging

This is inspired by the refactor in
sigstore/sigstore-python#372.

Signed-off-by: William Woodruff <[email protected]>

* README: update `pip-audit --help`

Signed-off-by: William Woodruff <[email protected]>

Signed-off-by: William Woodruff <[email protected]>
woodruffw added a commit to pypa/pip-audit that referenced this pull request Dec 29, 2022
@woodruffw @tetsuo-cpp
pip_audit, test: warn on Python path confusion (#451)
533ecf9 
* pip_audit, test: warn on Python path confusion

Closes #450.

Signed-off-by: William Woodruff <[email protected]>

* pip_audit, test: refactor check to use VIRTUAL_ENV

Signed-off-by: William Woodruff <[email protected]>

* pip_audit: remove commented code

Signed-off-by: William Woodruff <[email protected]>

* pip_audit, test: lintage

Signed-off-by: William Woodruff <[email protected]>

* CHANGELOG: record changes

Signed-off-by: William Woodruff <[email protected]>

* _cache: Remove remaining "Warning" prefix in log line

* _cli: refactor logging (#452)

* _cli: refactor logging

This is inspired by the refactor in
sigstore/sigstore-python#372.

Signed-off-by: William Woodruff <[email protected]>

* README: update `pip-audit --help`

Signed-off-by: William Woodruff <[email protected]>

Signed-off-by: William Woodruff <[email protected]>

* treewide: prep 2.4.11 (#453)

Signed-off-by: William Woodruff <[email protected]>
Co-authored-by: Alex Cameron <[email protected]>
timothy-bartlett added a commit to timothy-bartlett/pip-audit that referenced this pull request Aug 22, 2024
@timothy-bartlett
_cli: refactor logging (#452)
aa632d7 
* _cli: refactor logging

This is inspired by the refactor in
sigstore/sigstore-python#372.

Signed-off-by: William Woodruff <[email protected]>

* README: update `pip-audit --help`

Signed-off-by: William Woodruff <[email protected]>

Signed-off-by: William Woodruff <[email protected]>
timothy-bartlett added a commit to timothy-bartlett/pip-audit that referenced this pull request Aug 22, 2024
@timothy-bartlett @tetsuo-cpp
pip_audit, test: warn on Python path confusion (#451)
daa8108 
* pip_audit, test: warn on Python path confusion

Closes #450.

Signed-off-by: William Woodruff <[email protected]>

* pip_audit, test: refactor check to use VIRTUAL_ENV

Signed-off-by: William Woodruff <[email protected]>

* pip_audit: remove commented code

Signed-off-by: William Woodruff <[email protected]>

* pip_audit, test: lintage

Signed-off-by: William Woodruff <[email protected]>

* CHANGELOG: record changes

Signed-off-by: William Woodruff <[email protected]>

* _cache: Remove remaining "Warning" prefix in log line

* _cli: refactor logging (#452)

* _cli: refactor logging

This is inspired by the refactor in
sigstore/sigstore-python#372.

Signed-off-by: William Woodruff <[email protected]>

* README: update `pip-audit --help`

Signed-off-by: William Woodruff <[email protected]>

Signed-off-by: William Woodruff <[email protected]>

* treewide: prep 2.4.11 (#453)

Signed-off-by: William Woodruff <[email protected]>
Co-authored-by: Alex Cameron <[email protected]>
timothy-bartlett added a commit to timothy-bartlett/pip-audit that referenced this pull request Aug 22, 2024
@timothy-bartlett
_cli: refactor logging (#452)
f9f1fad 
* _cli: refactor logging

This is inspired by the refactor in
sigstore/sigstore-python#372.

Signed-off-by: William Woodruff <[email protected]>

* README: update `pip-audit --help`

Signed-off-by: William Woodruff <[email protected]>

Signed-off-by: William Woodruff <[email protected]>
timothy-bartlett added a commit to timothy-bartlett/pip-audit that referenced this pull request Aug 22, 2024
@timothy-bartlett @tetsuo-cpp
pip_audit, test: warn on Python path confusion (#451)
b41dd63 
* pip_audit, test: warn on Python path confusion

Closes #450.

Signed-off-by: William Woodruff <[email protected]>

* pip_audit, test: refactor check to use VIRTUAL_ENV

Signed-off-by: William Woodruff <[email protected]>

* pip_audit: remove commented code

Signed-off-by: William Woodruff <[email protected]>

* pip_audit, test: lintage

Signed-off-by: William Woodruff <[email protected]>

* CHANGELOG: record changes

Signed-off-by: William Woodruff <[email protected]>

* _cache: Remove remaining "Warning" prefix in log line

* _cli: refactor logging (#452)

* _cli: refactor logging

This is inspired by the refactor in
sigstore/sigstore-python#372.

Signed-off-by: William Woodruff <[email protected]>

* README: update `pip-audit --help`

Signed-off-by: William Woodruff <[email protected]>

Signed-off-by: William Woodruff <[email protected]>

* treewide: prep 2.4.11 (#453)

Signed-off-by: William Woodruff <[email protected]>
Co-authored-by: Alex Cameron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetsuo-cpp tetsuo-cpp tetsuo-cpp approved these changes

@di di Awaiting requested review from di

Assignees

@woodruffw woodruffw

Labels
component:cli CLI components refactoring Refactoring tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-think logging
2 participants
@woodruffw @tetsuo-cpp