Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加issues template 内容。 #616

Merged
merged 1 commit into from
Apr 26, 2018
Merged

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2018

添加Lable分类

@ghost
Copy link
Author

ghost commented Apr 26, 2018

@gaocegege @zhaobenx
你们看看我添加了Labels 的分类有没有问题。现在Labels主要是gaocegege在负责,这个规范了以后,我们也可以参与进来可以减轻一个人弄的负担。可能会好些。

@gaocegege
Copy link

SGTM

@zhaobenx
Copy link
Collaborator

我觉得可以建立,但是label的规则是不是就没必要写在issue的模板里呢?因为看到这些内容的人并没有家label的权限

@gaocegege
Copy link

是,可以我们达成共识就 OK 了。。

@ghost
Copy link
Author

ghost commented Apr 26, 2018

我是认为,对于其他人Label可以起到一个提醒作用吧,比如Source/unknown 这个Label, 别人看了模板就会知道这是一个不确定的消息来源。

Copy link
Collaborator

@zhaobenx zhaobenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那感觉可以

@gaocegege gaocegege added the lgtm label Apr 26, 2018
@sikaozhe1997 sikaozhe1997 merged commit 1d0cf9a into master Apr 26, 2018
@gaocegege gaocegege deleted the issues_template_edit branch April 26, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants