Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Version 0.3 #44

Merged
merged 114 commits into from
Apr 9, 2020
Merged

[WIP] Version 0.3 #44

merged 114 commits into from
Apr 9, 2020

Conversation

Luro02
Copy link
Collaborator

@Luro02 Luro02 commented Jan 23, 2020

See the milestone for more details.

Documentation is hard, especially in such a large project with so many files, this is the list of all files, where the documentation has to be reviewed:

src/

  • attribute.rs
  • error.rs
  • lib.rs
  • line.rs
  • master_playlist.rs
  • media_playlist.rs
  • media_segment.rs
  • traits.rs
  • utils.rs

src/tags/basic/

  • m3u.rs
  • version.rs

src/tags/master_playlist/

  • media.rs
  • session_data.rs
  • session_key.rs
  • variant_stream.rs

src/tags/media_playlist/

  • discontinuity_sequence.rs
  • end_list.rs
  • i_frames_only.rs
  • media_sequence.rs
  • playlist_type.rs
  • target_duration.rs

src/tags/media_segment/

  • byte_range.rs
  • date_range.rs
  • discontinuity.rs
  • inf.rs
  • key.rs
  • map.rs
  • program_date_time.rs

src/tags/shared/

  • independent_segments.rs
  • start.rs

src/types

  • byte_range.rs
  • channels.rs
  • closed_captions.rs
  • encryption_method.rs
  • float.rs
  • hdcp_level.rs
  • in_stream_id.rs
  • key_format.rs
  • key_format_versions.rs
  • media_type.rs
  • protocol_version.rs
  • resolution.rs
  • stream_data.rs
  • ufloat.rs
  • value.rs

closes #25
closes #31
closes #42

@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #44 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   76.26%   76.26%           
=======================================
  Files          44       44           
  Lines        1740     1740           
=======================================
  Hits         1327     1327           
  Misses        413      413           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a085971...a085971. Read the comment docs.

@Luro02 Luro02 added this to the 0.3 milestone Feb 2, 2020
src/attribute.rs Show resolved Hide resolved
dholroyd and others added 11 commits April 7, 2020 21:20
Although this goes against the wording of RFC8216, the spec includes
examples that omit this, and implementations also omit START-DATE when
for example signalling an 'explicit-IN' SCTE marker.
* fix EXT-X-MEDIA DEFAULT=yes wrt AUTOSELECT

In 4.3.4.1. EXT-X-MEDIA section about AUTOSELECT is written

   If the AUTOSELECT attribute is present, its value MUST be YES if
   the value of the DEFAULT attribute is YES.

That means, that if DEFAULT is YES and AUTOSELECT is *not present*, it
ok.

Before the patch, incorrect error is emitted

  If `DEFAULT` is true, `AUTOSELECT` has to be true too, Default:
  Some(true), Autoselect: None!

Signed-off-by: Nikola Pajkovsky <[email protected]>

* update src/tags/master_playlist/media.rs

Co-authored-by: Nikola Pajkovsky <[email protected]>
Co-authored-by: Lucas <[email protected]>
@Luro02
Copy link
Collaborator Author

Luro02 commented Apr 9, 2020

I think this is ready for merging :)

@Luro02 Luro02 merged commit 1057c90 into sile:master Apr 9, 2020
@Erk-
Copy link

Erk- commented Apr 9, 2020

Are two links to crates.io in the readme really needed ;P I think you added another one by accident.

@Luro02
Copy link
Collaborator Author

Luro02 commented Apr 9, 2020

@Erk- Thanks :)

Totally missed that. Fixed in 6d4e605.

@Erk-
Copy link

Erk- commented Apr 9, 2020

Yeah I meant where had changed the license shield to another crates shield, but it look like you fixed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ready for 0.3? Improve documentation Increase test coverage
5 participants