-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Version 0.3 #44
Conversation
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=======================================
Coverage 76.26% 76.26%
=======================================
Files 44 44
Lines 1740 1740
=======================================
Hits 1327 1327
Misses 413 413 Continue to review full report at Codecov.
|
Copy should not be implemented for types that implement Iterator, because this would be confusing. https://rust-lang.github.io/rust-clippy/master/#copy_iterator
Although this goes against the wording of RFC8216, the spec includes examples that omit this, and implementations also omit START-DATE when for example signalling an 'explicit-IN' SCTE marker.
Make START-DATE optional.
* fix EXT-X-MEDIA DEFAULT=yes wrt AUTOSELECT In 4.3.4.1. EXT-X-MEDIA section about AUTOSELECT is written If the AUTOSELECT attribute is present, its value MUST be YES if the value of the DEFAULT attribute is YES. That means, that if DEFAULT is YES and AUTOSELECT is *not present*, it ok. Before the patch, incorrect error is emitted If `DEFAULT` is true, `AUTOSELECT` has to be true too, Default: Some(true), Autoselect: None! Signed-off-by: Nikola Pajkovsky <[email protected]> * update src/tags/master_playlist/media.rs Co-authored-by: Nikola Pajkovsky <[email protected]> Co-authored-by: Lucas <[email protected]>
I think this is ready for merging :) |
Are two links to crates.io in the readme really needed ;P I think you added another one by accident. |
Yeah I meant where had changed the license shield to another crates shield, but it look like you fixed that. |
See the milestone for more details.
Documentation is hard, especially in such a large project with so many files, this is the list of all files, where the documentation has to be reviewed:
src/
src/tags/basic/
src/tags/master_playlist/
src/tags/media_playlist/
src/tags/media_segment/
src/tags/shared/
src/types
closes #25
closes #31
closes #42