Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to Go 1.23 #111

Merged
merged 1 commit into from
Oct 4, 2024
Merged

update to Go 1.23 #111

merged 1 commit into from
Oct 4, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Oct 2, 2024

Changed

  • Updated from Go 1.19 to 1.23

Removed

  • Removed matrix test now that personnel-sync is published as a binary rather than a library.

@briskt briskt requested review from a team, jason-jackson and hobbitronics and removed request for a team October 2, 2024 08:33
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

hobbitronics
hobbitronics approved these changes Oct 4, 2024
View reviewed changes
Copy link

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@briskt briskt merged commit 29415c4 into main Oct 4, 2024
3 checks passed
@briskt briskt deleted the develop branch October 9, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/go-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics