Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster setup should succeed without Honeycomb key #3453

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

andracc
Copy link
Collaborator

@andracc andracc commented Nov 19, 2024

Resolves #3409


This change is Reviewable

@andracc andracc self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.65%. Comparing base (cb9dcd1) to head (18fa480).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3453      +/-   ##
==========================================
+ Coverage   66.67%   74.65%   +7.97%     
==========================================
  Files         234      285      +51     
  Lines        5821    10999    +5178     
  Branches      706     1338     +632     
==========================================
+ Hits         3881     8211    +4330     
- Misses       1715     2404     +689     
- Partials      225      384     +159     
Flag Coverage Δ
backend 83.62% <ø> (?)
frontend 66.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andracc)

@andracc andracc marked this pull request as ready for review November 19, 2024 19:06
@andracc andracc merged commit 42000d7 into master Nov 19, 2024
18 checks passed
@andracc andracc deleted the honeycomb-access branch November 19, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[setup_cluster] --type development errors without HONEYCOMB_API_KEY
2 participants