Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/customize log and lift test coverage #28

Merged
merged 3 commits into from
Jul 27, 2020

Conversation

sillygod
Copy link
Owner

Purpose

Major to lift the test coverage and introduce the influxdb for log monitor

@@ -0,0 +1,71 @@
package influxlog
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

extends/influxlog/influx.go Outdated Show resolved Hide resolved
extends/influxlog/influx.go Outdated Show resolved Hide resolved
extends/influxlog/influx.go Outdated Show resolved Hide resolved
func (i *influxWriteCloser) Write(b []byte) (int, error) {
n := len(b)
content := string(b)
// TODO: parse the content {time} {level} {module} {messages}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO found

@codeclimate
Copy link

codeclimate bot commented Jul 27, 2020

Code Climate has analyzed commit 5d71454 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2
Bug Risk 1

The test coverage on the diff in this pull request is 21.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 50.6% (3.7% change).

View more on Code Climate.

@sillygod sillygod merged commit f37a969 into master Jul 27, 2020
@sillygod sillygod deleted the feature/customize_log_and_lift_test_coverage branch July 27, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant