Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We at Gitpod would like to use this great Caddy plugin for caching HTTP POST requests. Unfortunately, only GET and HEAD requests are supported yet. This PR adds the possibility to configure this plugin to cache HTTP POST requests as well.
This PR provides 2 commits:
http.request.contentlength
andhttp.request.bodyhash
.For caching POST requests it's important to distinguish requests with different body contents. The second commit adds
http.request.contentlength
andhttp.request.bodyhash
. For the body hash it's important that the cache key is calculated before the body has been read (before it's empty). Therefore the key is passed tofetchUpstream
.We would be happy if you would accept this change and thus expand the possibilities of the use of this plugin. Please let me know if you need anything else from me.