Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update readme to reflect lack of prettier yarn 2 support for automatic plugin discovery #52

Merged

Conversation

qbolt
Copy link
Contributor

@qbolt qbolt commented May 26, 2022

update readme to reflect lack of prettier yarn 2 support for automatic plugin discovery

Note: Yarn 2 does not yet support automatic plugin discovery. See the prettier documentation on plugins for alternatives to manually load them when using Yarn 2.

@simonhaenisch
Copy link
Owner

thanks for the PR but not sure this belongs here, shouldn't this be somewhere in the official Prettier docs? E. g. here it mentions automatic plugin discovery, seems like a good place to add this instead: https://prettier.io/docs/en/plugins.html#using-plugins

@qbolt
Copy link
Contributor Author

qbolt commented May 26, 2022

Hey, thanks for the response and suggestion. I agree it should be in the prettier docs and I'll make a note to add it there.

I think both places are helpful and will save time and hassle for people using yarn 2 to have this note. As more and more people adopt yarn 2, they may be coming to these docs to simply add a plugin and not understand why it's not being configured automatically as noted in the docs.

Since it has a peer dependency on prettier, I don't see any harm in noting this until prettier is updated.

@simonhaenisch simonhaenisch reopened this May 26, 2022
@simonhaenisch
Copy link
Owner

yeah i guess you're right even though i'm not personally a fan of yarn 😅

@simonhaenisch simonhaenisch merged commit 5ba4618 into simonhaenisch:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants