Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use read:org scope instead of user for accessing orgs #73

Closed
simonw opened this issue Feb 25, 2021 · 1 comment
Closed

Use read:org scope instead of user for accessing orgs #73

simonw opened this issue Feb 25, 2021 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Feb 25, 2021

if config.get("load_teams"):
scope = "read:org"
elif config.get("load_orgs"):
scope = "user"
else:
scope = "user:email"

user scope is actually quite frightening - it allows write access to the user profile! read:org should work just as well here.

@simonw simonw added the enhancement New feature or request label Feb 25, 2021
@simonw
Copy link
Owner Author

simonw commented Feb 25, 2021

I deployed this in an org-limited deployment and confirmed that it works.

@simonw simonw closed this as completed Feb 25, 2021
@simonw simonw added the bug Something isn't working label Feb 25, 2021
simonw added a commit that referenced this issue Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant