Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to 3.10.6-slim-bullseye Docker base image #1768

Closed
simonw opened this issue Jul 6, 2022 · 5 comments
Closed

Upgrade to 3.10.6-slim-bullseye Docker base image #1768

simonw opened this issue Jul 6, 2022 · 5 comments
Labels
docker The official Docker image, plus other things related to running Datasette on Docker
Milestone
Datasette 0.62

Comments

@simonw
Copy link
Owner

simonw commented Jul 6, 2022

For the package published to Docker Hub and also the containers used by datasette package and datasette publish cloudrun.
@simonw simonw added the docker The official Docker image, plus other things related to running Datasette on Docker label Jul 6, 2022
@simonw
Copy link
Owner Author

simonw commented Jul 6, 2022

Relevant Twitter thread: https://twitter.com/simonw/status/1544710944462254080

Looks like python:3.10-slim-bullseye is a good option, see https://pythonspeed.com/articles/base-image-python-docker-images/

@simonw
Copy link
Owner Author

simonw commented Jul 7, 2022

I tried this on Datasette Cloud and swapping datasetteproject/datasette to python:3.10-slim-bullseye as the base image dropped the overall image size from ~232MB to ~166MB - but note that I don't have SpatiaLite in that second image.

@simonw simonw added this to the Datasette 0.62 milestone Aug 14, 2022
@simonw
Copy link
Owner Author

simonw commented Aug 14, 2022

https://hub.docker.com/layers/python/library/python/3.10.6-slim-bullseye/images/sha256-cf85cd32e60184a94d88a0103c289d09024abffaa77680d116d7cc837668ea15?context=explore is the most recent - 3.10.6-slim-bullseye.

simonw added a commit that referenced this issue Aug 14, 2022
@simonw
Upgrade Docker baes to 3.10.6-slim-bullseye - refs #1768
668415d
simonw added a commit that referenced this issue Aug 14, 2022
@simonw
Switch to python:3.10.6-slim-bullseye for datasette publish - refs #1768
080d4b3
@simonw
Copy link
Owner Author

simonw commented Aug 14, 2022

Tested locally with:

datasette package fixtures.db --extra-options="--setting sql_time_limit_ms 2500" \
  -t datasette-package-python-upgrade

And then:

docker run -p 8081:8001 datasette-package-python-upgrade
INFO:     Started server process [8]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://0.0.0.0:8001 (Press CTRL+C to quit)

image

@simonw
Copy link
Owner Author

simonw commented Aug 14, 2022

Also trying this locally:

datasette publish cloudrun fixtures.db --service issue-1768

https://issue-1768-j7hipcg4aq-uc.a.run.app/-/versions

image

@simonw simonw closed this as completed Aug 14, 2022
@simonw simonw changed the title Switch to more recent, smaller Docker image Upgrade to 3.10.6-slim-bullseye Docker base image Aug 14, 2022
simonw added a commit that referenced this issue Aug 14, 2022
@simonw
Release 0.62
815162c 
Refs #903, #1300, #1683, #1701, #1712, #1717, #1718, #1728, #1733, #1738, #1739, #1744, #1746, #1748, #1759, #1766, #1768, #1770, #1773, #1779

Closes #1782
@simonw simonw mentioned this issue Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker The official Docker image, plus other things related to running Datasette on Docker
Projects
None yet
Milestone
Datasette 0.62
Development

No branches or pull requests
1 participant
@simonw