Let Composition types to rely on variadic tuple types #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed multi generic hack and use variadic tuple types which is introduced in TypeScript 4 BREAKING CHANGE: Requires TypeScript 4
|
Wow, thank you! This had been on my list of things to do for a while, so this PR is very much appreciated. The significant reduction of code leveraging variadics is absolutely wonderful. Happy to roll this PR through with the major revision to 4 (aligning with current revisions of the TypeScript compiler). Many thanks! |
|
@sinclairzx81 can you release a new version with this PR? |
|
@matomesc Hi mate, sorry yes, will be releasing this shortly, I did want to make a couple of updates before pushing this out to npm, but my current bandwidth to spend has been somewhat limited at present. Apologies there. Will push out a minor revision update out to npm today. |
|
@matomesc Have pushed an update for |
|
Thanks! |
github-actions bot
pushed a commit
to serverless-seoul/typebox
that referenced
this pull request
Jul 6, 2021
# [2.0.0](v1.1.0...v2.0.0) (2021-07-06) ### Bug Fixes * Allow intersect duplicated required ([sinclairzx81#68](https://github.com/catchfashion/typebox/issues/68)) ([e6de056](e6de056)) ### Features * merge upstream changes ([65eee4a](65eee4a)) * Let Composition types to rely on variadic tuple types (sinclairzx81#36) ([168c7ed](168c7ed)), closes [sinclairzx81#36](https://github.com/catchfashion/typebox/issues/36) ### BREAKING CHANGES * Requires TypeScript 4 * fix: make TModifier type to non-any type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13
Important Note
This PR changes minimum TypeScript version to v4 - which is potentially breaking change.