Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to press Ctrl-enter to copy package name #20

Merged
merged 14 commits into from
Jan 11, 2019

Conversation

mattfwood
Copy link
Contributor

Added "ctrl" as an argument to paste the name of the package using the clipboard action

index.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

sindresorhus commented Mar 6, 2018

Why do you specify the ctrl action both in the JS file and in the Alfred workflow?

@sindresorhus
Copy link
Owner

When pressing enter on a search result while holding Ctrl down, I get this:

screen shot 2018-03-06 at 19 29 47

@sindresorhus
Copy link
Owner

Ping @mattfwood

@mattfwood
Copy link
Contributor Author

@sindresorhus Sorry, I wasn't getting GitHub notifications for this for some reason. Let me take another look at and remove the redundancy,

@mattfwood
Copy link
Contributor Author

@sindresorhus
Okay, so the reason I have to specify the ctrl action as well as in the Alfred workflow is because the default behavior when an option is selected is to open the argument as a URL.

But since we don't want to open the package name (like 'chalk') as a URL, the workflow needs to handle the ctrl modifier differently, and copy it to the clipboard instead.

@sindresorhus
Copy link
Owner

I'm still getting the issue in #20 (comment)

@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

index.js Outdated Show resolved Hide resolved
info.plist Outdated Show resolved Hide resolved
info.plist Outdated Show resolved Hide resolved
test.js Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title FEATURE: added ctrl-select to paste package name Add feature to press Ctrl-enter to copy package name Dec 27, 2018
@sindresorhus
Copy link
Owner

It also needs to be documented in the readme.

@mattfwood
Copy link
Contributor Author

@sindresorhus Sorry this has been such a saga, but this time it should be all resolved.

Sorry for trying to implement this back when I had much less experience creating Alfred workflows.

@sindresorhus sindresorhus merged commit a6c3190 into sindresorhus:master Jan 11, 2019
sindresorhus added a commit that referenced this pull request Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants