-
-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'br' encoding #333
Add 'br' encoding #333
Conversation
Also, according to https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding, there's a possibilty for |
Is it worth adding a test for this maybe? Could use https://www.npmjs.com/package/brotli. |
That would add a devDep on https://github.com/mayhemydg/iltorb, which requires a native module. I don't think it's worth that as gzip is already tested. |
How do we decompress the |
iltorb can both compress and decompress. |
Yeah, but I mean when using |
Oh, right. Looks like https://github.com/sindresorhus/decompress-response is lacking support for |
The module I linked further up should handle it without native deps I think, https://github.com/devongovett/brotli.js. |
Haven't seen that one yet, but iltorb is well maintained and I haven't had any issues with it yet, even under Windows. Brotli compression is very CPU intensive, so I'd definitely compare the performance before choosing a module. |
Yup, I'll work on a PR, but I'm willing to sacrifice performance over native deps tbh depending on the impact. |
Opened sindresorhus/decompress-response#12 which blocks this issue. |
Node.js issue about adding it natively: nodejs/node#18964 |
Noticed that the greatest encoding out there was missing from this list.