Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ky to comparison table #895

Merged
merged 7 commits into from
Nov 1, 2019
Merged

Add ky to comparison table #895

merged 7 commits into from
Nov 1, 2019

Conversation

Airkro
Copy link
Contributor

@Airkro Airkro commented Oct 12, 2019

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates.

@Airkro Airkro marked this pull request as ready for review October 12, 2019 10:11
@Airkro Airkro changed the title Add ky to comparison Add ky to comparison table Oct 12, 2019
Copy link
Contributor

@sholladay sholladay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ky has a stream API as far as I am concerned. The API is a bit different since it uses WHATWG streams, and I suppose we don't have got-style shortcuts for it, but it's very easy to use.

Can't we also say Ky has Electron support, at least via ky-universal? Maybe that's not fair since it uses node-fetch to do so. 🤷‍♂️

For progress events, at the moment we have download progress, but not upload progress.

@Airkro
Copy link
Contributor Author

Airkro commented Oct 13, 2019

But node-fetch does not support electron, electron-fetch does, right?

@sholladay
Copy link
Contributor

I guess I assumed "Electron support" meant that it has to work in both main and renderer processes, which ky-universal should be able to, but node-fetch couldn't on its own. Or am I misunderstanding?

@Airkro
Copy link
Contributor Author

Airkro commented Oct 13, 2019

I guess "Electron support" mean support Electron's net module.

https://github.com/sindresorhus/got#useelectronnet

node-fetch use http module in nodejs.

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Ky supports progress events: https://github.com/sindresorhus/ky#ondownloadprogress

@Airkro
Copy link
Contributor Author

Airkro commented Nov 1, 2019

@sindresorhus
Copy link
Owner

Add it with * and explanation further down that upload is missing.

Editing comparison table
@sindresorhus sindresorhus merged commit 7dc42e6 into sindresorhus:master Nov 1, 2019
@sindresorhus
Copy link
Owner

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants