-
-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ky
to comparison table
#895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ky has a stream API as far as I am concerned. The API is a bit different since it uses WHATWG streams, and I suppose we don't have got
-style shortcuts for it, but it's very easy to use.
Can't we also say Ky has Electron support, at least via ky-universal
? Maybe that's not fair since it uses node-fetch
to do so. 🤷♂️
For progress events, at the moment we have download progress, but not upload progress.
But |
I guess I assumed "Electron support" meant that it has to work in both main and renderer processes, which |
I guess "Electron support" mean support Electron's https://github.com/sindresorhus/got#useelectronnet
|
Ky supports progress events: https://github.com/sindresorhus/ky#ondownloadprogress |
Add it with |
Editing comparison table
Thanks :) |
Checklist