Skip to content

Commit

Permalink
Drop Segoe UI Symbol as a fallback
Browse files Browse the repository at this point in the history
See the explanation in primer/css#906
  • Loading branch information
sindresorhus committed Dec 23, 2019
1 parent f37ff5a commit 6d5695a
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 8 deletions.
3 changes: 1 addition & 2 deletions modern-normalize.css
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ body {
Arial,
sans-serif,
'Apple Color Emoji',
'Segoe UI Emoji',
'Segoe UI Symbol';
'Segoe UI Emoji';
}

/*
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/chrome/rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ test('Remove the margin in all browsers.', async t => {

test('Improve consistency of default fonts in all browsers.', async t => {
await t
.expect(Selector('body').getStyleProperty('font-family')).eql(`system-ui, -apple-system, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol"`);
.expect(Selector('body').getStyleProperty('font-family')).eql(`system-ui, -apple-system, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"`);
});

test('Add the correct height in Firefox.', async t => {
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/chrome/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ test('Remove the margin in all browsers.', async t => {

test('Improve consistency of default fonts in all browsers.', async t => {
await t
.expect(Selector('body').getStyleProperty('font-family')).notEql('system-ui, -apple-system, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol"');
.expect(Selector('body').getStyleProperty('font-family')).notEql('system-ui, -apple-system, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"');
});

test('Add the correct height in Firefox.', async t => {
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/firefox/rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ test('Remove the margin in all browsers.', async t => {

test('Improve consistency of default fonts in all browsers.', async t => {
await t
.expect(Selector('body').getStyleProperty('font-family')).eql(`system-ui, -apple-system, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol"`);
.expect(Selector('body').getStyleProperty('font-family')).eql(`system-ui, -apple-system, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"`);
});

test('Add the correct height in Firefox.', async t => {
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/firefox/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ test('Remove the margin in all browsers.', async t => {

test('Improve consistency of default fonts in all browsers.', async t => {
await t
.expect(Selector('body').getStyleProperty('font-family')).notEql('system-ui, -apple-system, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol"');
.expect(Selector('body').getStyleProperty('font-family')).notEql('system-ui, -apple-system, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"');
});

test('Add the correct height in Firefox.', async t => {
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/safari/rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ test('Remove the margin in all browsers.', async t => {

test('Improve consistency of default fonts in all browsers.', async t => {
await t
.expect(Selector('body').getStyleProperty('font-family')).eql(`system-ui, -apple-system, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol"`);
.expect(Selector('body').getStyleProperty('font-family')).eql(`system-ui, -apple-system, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"`);
});

test('Add the correct height in Firefox.', async t => {
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/safari/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ test('Remove the margin in all browsers.', async t => {

test('Improve consistency of default fonts in all browsers.', async t => {
await t
.expect(Selector('body').getStyleProperty('font-family')).notEql('system-ui, -apple-system, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol"');
.expect(Selector('body').getStyleProperty('font-family')).notEql('system-ui, -apple-system, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"');
});

test('Add the correct height in Firefox.', async t => {
Expand Down

0 comments on commit 6d5695a

Please sign in to comment.