Tighten up multiArgs
TypeScript type constraints
#22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the type constraints by using rest elements/spread types by default, and treating the single-argument (non-multiArgs) case as special by passing it to
Emitter
as[EmittedType]
(note the brackets, making it a single element tuple).This provides better ergonomics on iterator, e.g.: this case with Express:
Comparison
Relative to what version 3.0 emits for types:
Using
iterator<[Request, Response]>
This doesn't make sense, because it's not an array of [Request, Response] tuples.
Using
iterator<Request, [Response]>
This doesn't make sense because the first argument is never a
Response
, and the second argument is never aRequest
, but indeed, this type checks, but it cannot possibly be true: